Re: Replication server timeout patch

Fujii Masao <masao.fujii@gmail.com>

From: Fujii Masao <masao.fujii@gmail.com>

To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Josh Berkus <josh@agliodbs.com>, pgsql-hackers@postgresql.org

Date: 2011-03-30T08:08:22Z

Lists: pgsql-hackers

On Wed, Mar 30, 2011 at 5:03 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> On 30.03.2011 10:58, Fujii Masao wrote:
>>
>> On Wed, Mar 30, 2011 at 4:24 PM, Heikki Linnakangas
>> <heikki.linnakangas@enterprisedb.com>  wrote:
>> +        A value of zero means wait forever.  This parameter can only be
>> set in
>>
>> The first sentence sounds misleading. Even if you set the parameter to
>> zero,
>> replication connections can be terminated because of keepalive or socket
>> error.
>
> Hmm, should I change it back to "A value of zero disables the timeout" ? Any
> better suggestions?

I like that. But I appreciate if anyone suggests the better.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center