Re: Fix typo 586/686 in atomics/arch-x86.h

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Andres Freund <andres@anarazel.de>

Cc: Tomas Vondra <tv@fuzzy.cz>, Jakub Wartak <jakub.wartak@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Thomas Munro <thomas.munro@gmail.com>

Date: 2026-05-07T20:59:26Z

Lists: pgsql-hackers

Attachments

0001-Remove-support-for-8-byte-tear-free-read-write-on-32.patch (application/octet-stream)

> On 11 Mar 2026, at 16:51, Andres Freund <andres@anarazel.de> wrote:

> I do think we should drop the 32bit support, rather than fixing the typos.

Attached is a patch against HEAD for this.  Reading your mail my interpretation
was that this was equally broken for MSVC even though the macro is correct
there, and we should remove both.  Was that a correct reading?

I'm not sure it's worth doing this to the backbranches, seems like we can keep
this a v19+ fix.

--
Daniel Gustafsson