Horton

Re: datfrozenxid > relfrozenxid w/ crash before XLOG_HEAP_INPLACE

x4mmm@yandex-team.ru

View thread View on postgr.es
From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2024-06-20T07:17:44Z
Lists: pgsql-hackers 

> On 20 Jun 2024, at 06:29, Noah Misch <noah@leadboat.com> wrote:
> 
> This resolves the last inplace update defect known to me.

That’s a huge amount of work, thank you!

Do I get it right, that inplace updates are catalog-specific and some other OOM corruptions [0] and Standby corruptions [1] are not related to this fix. Bot cases we observed on regular tables.
Or that might be effect of vacuum deepening corruption after observing wrong datfrozenxid?


Best regards, Andrey Borodin.

[0] https://www.postgresql.org/message-id/flat/67EADE8F-AEA6-4B73-8E38-A69E5D48BAFE%40yandex-team.ru#1266dd8b898ba02686c2911e0a50ab47
[1] https://www.postgresql.org/message-id/flat/CAFj8pRBEFMxxFSCVOSi-4n0jHzSaxh6Ze_cZid5eG%3Dtsnn49-A%40mail.gmail.com

Commits

  1. WAL-log inplace update before revealing it to other sessions.

  2. Comment on need to MarkBufferDirty() if omitting DELAY_CHKPT_START.