Horton

Re: Patch bug: Fix jsonpath .* on Arrays

David E. Wheeler <david@justatheory.com>

View thread View on postgr.es
From: "David E. Wheeler" <david@justatheory.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Stepan Neretin <sncfmgg@gmail.com>, Степан Неретин <fenixrnd@mail.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "David G. Johnston" <david.g.johnston@gmail.com>
Date: 2024-06-27T15:05:31Z
Lists: pgsql-hackers 
On Jun 27, 2024, at 04:17, Michael Paquier <michael@paquier.xyz> wrote:

> The tests of jsonb_jsonpath.sql include a lot of patterns for @? and
> jsonb_path_query with the lax and strict modes, so shouldn't these
> additions be grouped closer to the existing tests rather than added at 
> the end of the file?

I think you could argue that they should go with other tests for array unwrapping, though it’s kind of mixed throughout. But that’s more the bit I was testing; almost all the tests are lax, and it’s less the strict behavior to test here than the explicit behavior of unwrapping in lax mode.

But ultimately I don’t care where they go, just that we have them.

D

Commits

  1. Add more test coverage for jsonpath "$.*" with arrays