Horton

Re: "openssl" should not be optional

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-24T15:49:11Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid warnings in tests when openssl binary isn't available

> On 24 Sep 2025, at 17:13, Christoph Berg <myon@debian.org> wrote:
> 
> Re: Daniel Gustafsson
>> Looking at this I was reminded that we already handle this by using a fallback
>> and the test worked all along.  The message for this was quite poorly worded
>> though, and used a warning instead of a note.  The attached will try to detect
>> openssl being missing before trying to run it, and will skip the warning
>> message if the fallback is used (which really isn't a warning in the first
>> place).
> 
> Thanks, I just built the postgresql-18 again with this patch (and
> openssl not installed [*]). It passes fine now.
> 
> In the meantime, I also got the report that postgresql-17 is not
> failing in that environment, so the problem is new in 18.

That's odd, off the cuff I don't see anything materially different around this
but I'll do some more digging.  It will at least be fixed by 18.1.

--
Daniel Gustafsson