Re: Autovacuum on partitioned table (autoanalyze)

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: yuzuko <yuzukohosoya@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Amit Langote <amitlangote09@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Greg Stark <stark@mit.edu>
Date: 2020-08-01T21:50:59Z
Lists: pgsql-hackers
> On 6 Jul 2020, at 12:35, yuzuko <yuzukohosoya@gmail.com> wrote:
> 
>> On Wed, Jul 1, 2020 at 6:26 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> 
>>> On 21 Apr 2020, at 18:21, yuzuko <yuzukohosoya@gmail.com> wrote:
>> 
>>> I'll update the patch soon.
>> 
>> Do you have an updated version to submit?  The previous patch no longer applies
>> to HEAD, so I'm marking this entry Waiting on Author in the meantime.
>> 
> Thank you for letting me know.
> I attach the latest patch applies to HEAD.

This version seems to fail under Werror which is used in the Travis builds:

autovacuum.c: In function ‘relation_needs_vacanalyze’:
autovacuum.c:3117:59: error: ‘reltuples’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
                                                           ^
autovacuum.c:2972:9: note: ‘reltuples’ was declared here
  float4  reltuples;  /* pg_class.reltuples */
         ^

I've moved this patch to the next commitfest, but kept the status as Waiting on
Author.  Please submit a new version of the patch.

cheers ./daniel


Commits

  1. Keep stats up to date for partitioned tables

  2. Revert analyze support for partitioned tables

  3. Document ANALYZE storage parameters for partitioned tables

  4. autovacuum: handle analyze for partitioned tables