Re: BUG #18224: message bug in libpqwalreceiver.c.

> On 10 Dec 2023, at 05:00, Alexander Lakhin <exclusion@gmail.com> wrote:
> 
> Hello Daniel,
> 
> 05.12.2023 16:44, Daniel Gustafsson wrote:
>> Following the bouncing ball it turns out that restricting to 9.4+ (effectively
>> reapplying 083d29c65b78 adapted to the callsites moved to a common function)
>> across the board isn't doable since pg_basebackup requires IDENTIFY_SYSTEM for
>> 9.1->9.3 to get the starttli.  Thus I opted for just fixing the error message
>> and left the restriction on 9.4+ as future work for when it can be done across
>> all callers.
> 
> Isn't IDENTIFY_SERVER a mistake in the comment added?:
> 
> +     * IDENTIFY_SERVER returns 3 columns in 9.3 and earlier, and 4 columns in
> +     * 9.4 and onwards.

Ugh, yes, fixing.

--
Daniel Gustafsson