Re: Fix a typo in pg_rotate_logfile

> On 14 Feb 2024, at 19:51, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> On Wed, Feb 14, 2024 at 10:04:49AM -0500, Tom Lane wrote:
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 14 Feb 2024, at 11:35, Dave Page <dpage@pgadmin.org> wrote:
>>>> That said, pgAdmin III has been out of support for many years, and as
>>>> far as I know, it (and similarly old versions of EDB's PEM which was
>>>> based on it) were the only consumers of adminpack. I would not be sad
>>>> to see it removed entirely
>> 
>>> Searching on Github and Debian Codesearch I cannot find any reference to anyone
>>> using any function from adminpack.  With pgAdminIII being EOL it might be to
>>> remove it now rather than be on the hook to maintain it for another 5 years
>>> until v17 goes EOL.  It'll still be around for years in V16->.
>> 
>> Works for me.
>> 
>>> Attached is a diff to show what it would look like to remove adminpack (catalog
>>> version bump omitted on purpose to avoid conflicts until commit).
>> 
>> I don't see any references you missed, so +1.
> 
> Seems reasonable to me, too.

Thanks!  I'll put this in the next CF to keep it open for comments a bit
longer, but will close it early in the CF.

--
Daniel Gustafsson