Horton

Thread

Commits

  1. Remove custom memory allocation layer in pgcrypto

  1. Memory allocation abstraction in pgcrypto

    Daniel Gustafsson <daniel@yesql.se> — 2020-09-18T20:00:04Z

    pgcrypto has an abstraction for palloc/pfree via PX_OWN_ALLOC with the
intention to make it easy to swap out for another allocator.  There are however
a number of palloc calls that have snuck in over the years, so the abstraction
is leaking a fair bit making it less useful.  Since there have been no
complaints that I can see (searching the archives for PX_OWN_ALLOC yields zero
threads, and px_alloc none about this topic) then maybe it's time to remove it
and simplify the code?

The attached removes it in favor of using palloc() et.al directly.  Is there
any reason to keep it around still?

cheers ./daniel

  2. Re: Memory allocation abstraction in pgcrypto

    Michael Paquier <michael@paquier.xyz> — 2020-09-23T07:57:44Z

    On Fri, Sep 18, 2020 at 10:00:04PM +0200, Daniel Gustafsson wrote:
> The attached removes it in favor of using palloc() et.al directly.  Is there
> any reason to keep it around still?

I doubt that anybody has been compiling with PX_OWN_ALLOC in the last
years, so let's remove this abstraction.  And +1 for your patch.
--
Michael

  3. Re: Memory allocation abstraction in pgcrypto

    Michael Paquier <michael@paquier.xyz> — 2020-09-25T01:27:39Z

    On Wed, Sep 23, 2020 at 04:57:44PM +0900, Michael Paquier wrote:
> I doubt that anybody has been compiling with PX_OWN_ALLOC in the last
> years, so let's remove this abstraction.  And +1 for your patch.

So, I have looked at that this morning again, and applied the thing.
--
Michael