Re: new heapcheck contrib module

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@bowt.ie>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>, Amul Sul <sulamul@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-01-11T18:16:07Z

Lists: pgsql-hackers

Attachments

v32-0001-Moving-exit_nicely-and-fatal-into-fe_utils.patch (application/octet-stream) patch v32-0001
v32-0002-Refactoring-ExecuteSqlQuery-and-related-function.patch (application/octet-stream) patch v32-0002
v32-0003-Creating-query_utils-frontend-utility.patch (application/octet-stream) patch v32-0003
v32-0004-Adding-CurrentQueryHandler-logic.patch (application/octet-stream) patch v32-0004
v32-0005-Refactoring-pg_dumpall-functions.patch (application/octet-stream) patch v32-0005
v32-0006-Refactoring-expand_schema_name_patterns-and-frie.patch (application/octet-stream) patch v32-0006
v32-0007-Moving-pg_dump-functions-to-new-file-option_util.patch (application/octet-stream) patch v32-0007
v32-0008-Normalizing-option_utils-interface.patch (application/octet-stream) patch v32-0008
v32-0009-Adding-contrib-module-pg_amcheck.patch (application/octet-stream) patch v32-0009
(unnamed) (text/plain)


> On Jan 10, 2021, at 12:41 PM, Thomas Munro <thomas.munro@gmail.com> wrote:
> 
> On Fri, Jan 8, 2021 at 6:33 AM Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>> The attached patches, v31, are mostly the same, but with "getopt_long.h" included from pg_amcheck.c per Thomas's review, and a .gitignore file added in contrib/pg_amcheck/
> 
> I couple more little things from Windows CI:
> 
>    C:\projects\postgresql\src\include\fe_utils/option_utils.h(19):
> fatal error C1083: Cannot open include file: 'libpq-fe.h': No such
> file or directory [C:\projects\postgresql\pg_amcheck.vcxproj]
> 
> Does contrib/amcheck/Makefile need to say "SHLIB_PREREQS =
> submake-libpq" like other contrib modules that use libpq?

Added in v32.

>    pg_backup_utils.obj : error LNK2001: unresolved external symbol
> exit_nicely [C:\projects\postgresql\pg_dump.vcxproj]
> 
> I think this is probably because additions to src/fe_utils/Makefile's
> OBJS list need to be manually replicated in
> src/tools/msvc/Mkvcbuild.pm's @pgfeutilsfiles list.  (If I'm right
> about that, perhaps it needs a comment to remind us Unix hackers of
> that, or perhaps it should be automated...)

Added in v32, along with adding pg_amcheck to @contrib_uselibpq, @contrib_uselibpgport, and @contrib_uselibpgcommon

There are also a few additions in v32 to typedefs.list, and some whitespace changes due to running pgindent.

Commits

Add pg_amcheck, a CLI for contrib/amcheck.
- 9706092839db 14.0 landed
Refactor and generalize the ParallelSlot machinery.
- f71519e545a3 14.0 landed
Generalize parallel slot result handling.
- 418611c84d00 14.0 landed
Move some code from src/bin/scripts to src/fe_utils to permit reuse.
- e955bd4b6c2b 14.0 landed
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 landed
Doc: clean up verify_heapam() documentation.
- 4c49d8fc15ee 14.0 landed
Fix more portability issues in new amcheck code.
- 321633e17b07 14.0 landed
Fix portability issues in new amcheck test.
- 860593ec3bd1 14.0 landed
Try to avoid a compiler warning about using fxid uninitialized.
- 8bb0c9770e80 14.0 landed
Extend amcheck to check heap pages.
- 866e24d47db1 14.0 landed
Adjust walsender usage of xlogreader, simplify APIs
- 850196b610d2 13.0 cited
Improve checking of child pages in contrib/amcheck.
- d114cc538715 13.0 cited
Sanitize line pointers within contrib/amcheck.
- a9ce839a3137 12.0 cited
Fix possible sorting error when aborting use of abbreviated keys.
- 008c4135ccf6 10.0 cited