Re: pg_receivewal and SIGTERM
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Christoph Berg <myon@debian.org>,
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-25T09:19:05Z
Lists: pgsql-hackers
Attachments
- v2-0001-Handle-SIGTERM-in-pg_receivewal-and-pg_recvlogica.patch (application/octet-stream) patch v2-0001
> On 23 Aug 2022, at 02:15, Michael Paquier <michael@paquier.xyz> wrote: > > On Mon, Aug 22, 2022 at 04:05:16PM +0200, Christoph Berg wrote: >> Do you mean it can, or can not be backpatched? (I'd argue for >> backpatching since the behaviour is slightly broken at the moment.) > > I mean that it is fine to backpatch that, in my opinion. I think this can be argued both for and against backpatching. Catching SIGTERM makes a lot of sense, especially given systemd's behavior. On the other hand, This adds functionality to something arguably working as intended, regardless of what one thinks about the intent. The attached adds the Exit Status section to pg_recvlogical docs which is present in pg_receivewal to make them more aligned, and tweaks comments to pgindent standards. This is the version I think is ready to commit. -- Daniel Gustafsson https://vmware.com/
Commits
-
Handle SIGTERM in pg_receivewal and pg_recvlogical
- 8b60db774356 16.0 landed
-
doc: Add missing parenthesis to keycombo
- 6cbed0ec791f 16.0 landed
- 207fc7546644 15.0 landed