Re: pg14 psql broke \d datname.nspname.relname

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Greg Stark <stark@mit.edu>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Justin Pryzby <pryzby@telsasoft.com>, Stephen Frost <sfrost@snowman.net>, Peter Geoghegan <pg@bowt.ie>

Date: 2022-04-20T02:20:19Z

Lists: pgsql-hackers

Attachments

v14-0001-Reject-patterns-with-too-many-parts-or-wrong-db.patch (application/octet-stream) patch v14-0001
v15-0001-Reject-patterns-with-too-many-parts-or-wrong-db.patch (application/octet-stream) patch v15-0001
(unnamed) (text/plain)

> On Apr 19, 2022, at 7:00 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> (A) This is a new feature. Wait for v16.
> (B) This is a bug fix. Commit it now and back-patch to v14.
> (C) This is a cleanup that is OK to put into v15 even after feature
> freeze but since it is a behavior change we shouldn't back-patch it.
> 
> I vote for (C). What do other people think?

Looks like most people voted for (B).  In support of that option, here are patches for master and REL_14_STABLE.  Note that I extended the tests compared to v9, which found a problem that is fixed for v10:

Commits

Remove some recently-added pg_dump test cases.
- 75a006beef6c 14.3 landed
- a66e722cc118 15.0 landed
Allow db.schema.table patterns, but complain about random garbage.
- 4a66300acd8c 14.3 landed
- d2d35479796c 15.0 landed
Improve error handling of HMAC computations
- 5513dc6a304d 15.0 cited
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 cited