Pithy patch for more detailed error reporting when effective_io_concurrency is set to nonzero on platforms lacking posix_fadvise()

James Robinson <james@jlr-photo.com>

From: James Robinson <james@jlr-photo.com>

To: pgsql-hackers@postgresql.org

Date: 2018-09-28T18:30:36Z

Lists: pgsql-hackers

Attachments

no_fadvise_better_warning_bug_15396.patch (application/octet-stream) patch
(unnamed) (text/plain)

Per Tom's suggestion on bug #15396, here's a patch to have platforms such as OSX give a more descriptive message when rejecting a nonzero value for effective_io_concurrency.

I had to adjust the GUC's wiring in the #ifndef case so that check_effective_io_concurrency() would be called when a nonzero value is supplied instead of just short-circuiting in parse_and_validate_value() when outside of [conf->min, conf->max].

James

Commits

Improve error reporting for unsupported effective_io_concurrency setting.
- a8fb03fceadb 11.0 landed
- 2b04dfc47249 12.0 landed