Re: Add SQL function for SHA1

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Noah Misch <noah@leadboat.com>

Cc: Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-01-26T09:38:43Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor SQL functions of SHA-2 in cryptohashfuncs.c
- f854c69a5b36 14.0 landed

> On 26 Jan 2021, at 04:28, Noah Misch <noah@leadboat.com> wrote:
> 
> On Mon, Jan 25, 2021 at 10:12:28PM +0900, Michael Paquier wrote:
>> SHA-1 is now an option available for cryptohashes, and like the
>> existing set of functions of SHA-2, I don't really see a reason why we
>> should not have a SQL function for SHA1.
> 
> NIST deprecated SHA1 over ten years ago.  It's too late to be adding this.

Agreed, and pgcrypto already allows for using sha1.

It seems like any legitimate need for sha1 could be better served by an
extension rather than supplying it in-core.

--
Daniel Gustafsson		https://vmware.com/