RE: AIX support
Srirama Kucherlapati <sriram.rk@in.ibm.com>
From: Srirama Kucherlapati <sriram.rk@in.ibm.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>,
Heikki Linnakangas <hlinnaka@gmail.com>,
Bruce Momjian <bruce@momjian.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
Alvaro Herrera <alvherre@alvh.no-ip.org>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
Laurenz Albe <laurenz.albe@cybertec.at>,
Noah
Misch <noah@leadboat.com>, Michael Paquier <michael@paquier.xyz>,
Andres
Freund <andres@anarazel.de>,
Thomas Munro <thomas.munro@gmail.com>,
"tvk1271@gmail.com" <tvk1271@gmail.com>,
"postgres-ibm-aix@wwpdl.vnet.ibm.com"
<postgres-ibm-aix@wwpdl.vnet.ibm.com>,
Tom Lane <tgl@sss.pgh.pa.us>
Date: 2024-09-25T06:04:45Z
Lists: pgsql-hackers
Hi Heikki, As requested earlier, I need some assistance from the Postgres side to identify any tool or testcase to calibrate the sync routine performance in Postgres. I see the below tools for benchmarking. * Pgbench https://www.postgresql.org/docs/current/pgbench.html * Pg_test_fsync https://www.postgresql.org/docs/current/pgtestfsync.html * pg_test_timing https://www.postgresql.org/docs/current/pgtesttiming.html Please let me know, if these tools are fine or else ca you suggest us with any additional tools to run the benchmarking. > > Ok, if we don't need the assembler code at all, that's good. A patch to > > introduce AIX support should not change it for non-AIX powerpc systems > > though. That might be a good change, but would need to be justified > > separately, e.g. by some performance testing, and should be a separate > > patch. > > If you make no changes to s_lock.h at all, will it work? Why not? > With the existing asm code I see there are some syntax errors, being hit. > But after reverting the old changes the issues resolved. Below are diffs. > Let me know if I need to run any perf tools to check the performance of > the __sync_lock_test_and_set change. Thanks, Sriram.