Horton

Re: Unchecked strdup leading to segfault in pg_dump

Tristan Partin <tristan@neon.tech>

View thread View on postgr.es
From: "Tristan Partin" <tristan@neon.tech>
To: "Daniel Gustafsson" <daniel@yesql.se>
Cc: "Postgres hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-20T15:39:55Z
Lists: pgsql-hackers 
On Wed Dec 20, 2023 at 8:52 AM CST, Daniel Gustafsson wrote:
> While looking at something else I noticed that pg_dump performs strdup without
> checking the returned pointer, which will segfault in hasSuffix() in case of
> OOM.  The attached, which should be backpatched to 16, changes to using
> pg_strdup instead which handles it.

Looks good to me.

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

  1. Fix unchecked return value from strdup