Horton

Re: Remove MSVC scripts from the tree

Tristan Partin <tristan@neon.tech>

View thread View on postgr.es
From: "Tristan Partin" <tristan@neon.tech>
To: "Peter Eisentraut" <peter@eisentraut.org>, "vignesh C" <vignesh21@gmail.com>, "Michael Paquier" <michael@paquier.xyz>
Cc: "Shubham Khanna" <khannashubham1197@gmail.com>, "Andres Freund" <andres@anarazel.de>, "Postgres hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-19T16:10:45Z
Lists: pgsql-hackers 
On Tue Dec 19, 2023 at 9:24 AM CST, Peter Eisentraut wrote:
> On 18.12.23 14:52, Peter Eisentraut wrote:
> >> 2) I had seen that if sed/gzip is not available meson build will fail:
> >> 2.a)
> >> Program gsed sed found: NO
> >> meson.build:334:6: ERROR: Program 'gsed sed' not found or not executable
> > 
> > Yes, this would need to be improved.  Currently, sed is only required if 
> > either selinux or dtrace is enabled, which isn't supported on Windows. 
> > But we should adjust the build scripts to not fail the top-level setup 
> > run unless those options are enabled.
> > 
> >> 2.b)
> >> Program gzip found: NO
> >> meson.build:337:7: ERROR: Program 'gzip' not found or not executable
> > 
> > gzip is only required for certain test suites, so again we should adjust 
> > the build scripts to not fail the build but instead skip the tests as 
> > appropriate.
>
> Here are patches for these two issues.  More testing would be appreciated.

Meson looks good to me!

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

  1. Make win32tzlist.pl checkable again

  2. meson: Make gzip and tar optional

  3. meson: Make sed optional

  4. Remove MSVC scripts

  5. Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl