Horton

Re: Add --check option to pgindent

Tristan Partin <tristan@neon.tech>

View thread View on postgr.es
From: "Tristan Partin" <tristan@neon.tech>
To: "Tristan Partin" <tristan@neon.tech>, "Jelte Fennema-Nio" <postgres@jeltef.nl>, "Daniel Gustafsson" <daniel@yesql.se>
Cc: "Andrew Dunstan" <andrew@dunslane.net>, "Alvaro Herrera" <alvherre@alvh.no-ip.org>, "Tom Lane" <tgl@sss.pgh.pa.us>, "Euler Taveira" <euler@eulerto.com>, "Michael Banck" <mbanck@gmx.net>, "PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Date: 2023-12-19T15:33:54Z
Lists: pgsql-hackers 
On Mon Dec 18, 2023 at 3:18 PM CST, Tristan Partin wrote:
> On Mon Dec 18, 2023 at 10:50 AM CST, Tristan Partin wrote:
> > On Mon Dec 18, 2023 at 10:14 AM CST, Jelte Fennema-Nio wrote:
> > > On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson <daniel@yesql.se> wrote:
> > > > I think this is pretty much ready to go, the attached v4 squashes the changes
> > > > and fixes the man-page which also needed an update.  The referenced Wiki page
> > > > will need an edit or two after this goes in, but that's easy enough.
> > >
> > > One thing I'm wondering: When both --check and --diff are passed,
> > > should pgindent still early exit with 2 on the first incorrectly
> > > formatted file? Or should it show diffs for all failing files? I'm
> > > leaning towards the latter making more sense.
> >
> > Makes sense. Let me iterate on the squashed version of the patch.
>
> Here is an additional patch which implements the behavior you described. 
> The first patch is just Daniel's squashed version of my patches.

Assuming all this is good, I now have access to edit the Wiki. The PR 
for buildfarm client code is up, and hopefully that PR is correct.

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

  1. Rename pgindent options