Re: typedefs.list glitches

Tristan Partin <tristan@neon.tech>

From: "Tristan Partin" <tristan@neon.tech>
To: "Tom Lane" <tgl@sss.pgh.pa.us>, "Andrew Dunstan" <andrew@dunslane.net>
Cc: <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-12T15:37:29Z
Lists: pgsql-hackers
On Thu May 12, 2022 at 4:21 PM CDT, Tom Lane wrote:
> I wrote:
> > every buildfarm member that's contributing to the typedefs list
> > builds with OpenSSL.  That wouldn't surprise me, except that
> > my own animal sifaka should be filling that gap.  Looking at
> > its latest attempt[1], it seems to be generating an empty list,
> > which I guess means that our recipe for extracting typedefs
> > doesn't work on macOS/arm64.  I shall investigate.
>
> Found it.  Current macOS produces
>
> $ objdump -W
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/objdump: error: unknown argument '-W'
>
> where last year's vintage produced
>
> $ objdump -W
> objdump: Unknown command line argument '-W'.  Try: '/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/objdump --help'
> objdump: Did you mean '-C'?
>
> This confuses run_build.pl into taking the "Linux and sometimes windows"
> code path instead of the $using_osx one.  I think simplest fix is to
> move the $using_osx branch ahead of the heuristic ones, as attached.

Hey Tom,

Was this patch ever committed?

-- 
Tristan Partin
Neon (https://neon.tech)



Commits

  1. Rename JsonIsPredicate.value_type, fix JSON backend/nodes/ infrastructure.