Horton

Re: pg_upgrade --check fails to warn about abstime

Tristan Partin <tristan@neon.tech>

View thread View on postgr.es
From: "Tristan Partin" <tristan@neon.tech>
To: "Alvaro Herrera" <alvherre@alvh.no-ip.org>
Cc: "Pg Hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2023-09-20T17:45:36Z
Lists: pgsql-hackers 
> +/*
> + * check_for_removed_data_type_usage
> + *
> + *        similar to the above, but for types that were removed in 12.
> + */
> +static void
> +check_for_removed_data_type_usage(ClusterInfo *cluster, const char *datatype)

Seems like you could make this more generic instead of hardcoding 
version 12, and then you could use it for any future removed types as 
well.

Just a thought.

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

  1. pg_upgrade: check for types removed in pg12