Re: Improve const use in zlib-using code
Tristan Partin <tristan@neon.tech>
From: "Tristan Partin" <tristan@neon.tech>
To: "Peter Eisentraut" <peter@eisentraut.org>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Date: 2023-08-02T14:39:00Z
Lists: pgsql-hackers
Peter,
I like the idea. Though the way you have it implemented at the moment
seems like a trap in that any time zlib.h is included someone also has
to remember to add this define. I would recommend adding the define to
the build systems instead.
Since you put in the work to find the version of zlib that added this,
You might also want to add `required: '>= 1.2.5.2'` to the
`dependency('zlib')` call in the main meson.build. I am wondering if we
could remove the `z_streamp` check too. The version that it was added
isn't obvious.
--
Tristan Partin
Neon (https://neon.tech)
Commits
-
Improve const use in zlib-using code
- 67c0ef9752ad 17.0 landed
-
Remove configure check for z_streamp
- eeb4eeea2c52 17.0 landed