Re: Clean up some signal usage mainly related to Windows

Tristan Partin <tristan@neon.tech>

From: "Tristan Partin" <tristan@neon.tech>

To: "Peter Eisentraut" <peter@eisentraut.org>, <pgsql-hackers@postgresql.org>

Date: 2023-07-12T14:35:58Z

Lists: pgsql-hackers

Attachments

v3-0002-Cleanup-some-signal-usage-on-Windows.patch (text/x-patch) patch v3-0002
v3-0001-Use-signal-safe-functions-in-signal-handler.patch (text/x-patch) patch v3-0001

On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
> On 12.07.23 16:23, Tristan Partin wrote:
> > It has come to my attention that STDOUT_FILENO might not be portable and
> > fileno(3) isn't marked as signal-safe, so I have just used the raw 1 for
> > stdout, which as far as I know is portable.
>
> We do use STDOUT_FILENO elsewhere in the code, and there are even 
> workaround definitions for Windows, so it appears it is meant to be used.

v3 is back to the original patch with newline being printed. Thanks.

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

Suppress -Wunused-result warning about write().
- c2a465b2c94f 17.0 landed
Use signal-safe functions in signal handler
- 52e98d450230 17.0 landed