Re: Clean up some signal usage mainly related to Windows
Tristan Partin <tristan@neon.tech>
From: "Tristan Partin" <tristan@neon.tech>
To: "Peter Eisentraut" <peter@eisentraut.org>,
<pgsql-hackers@postgresql.org>
Date: 2023-07-12T14:23:06Z
Lists: pgsql-hackers
Attachments
- v2-0002-Cleanup-some-signal-usage-on-Windows.patch (text/x-patch) patch v2-0002
- v2-0001-Use-signal-safe-functions-in-signal-handler.patch (text/x-patch) patch v2-0001
On Wed Jul 12, 2023 at 3:56 AM CDT, Peter Eisentraut wrote:
> On 06.07.23 22:43, Tristan Partin wrote:
> > /* Finish incomplete line on stdout */
> > - puts("");
> > - exit(1);
> > + write(STDOUT_FILENO, "", 1);
> > + _exit(1);
>
> puts() writes a newline, so it should probably be something like
>
> write(STDOUT_FILENO, "\n", 1);
Silly mistake. Thanks. v2 attached.
It has come to my attention that STDOUT_FILENO might not be portable and
fileno(3) isn't marked as signal-safe, so I have just used the raw 1 for
stdout, which as far as I know is portable.
--
Tristan Partin
Neon (https://neon.tech)
Commits
-
Suppress -Wunused-result warning about write().
- c2a465b2c94f 17.0 landed
-
Use signal-safe functions in signal handler
- 52e98d450230 17.0 landed