Re: check_strxfrm_bug()
Tristan Partin <tristan@neon.tech>
From: "Tristan Partin" <tristan@neon.tech>
To: "Thomas Munro" <thomas.munro@gmail.com>, "Noah Misch"
<noah@leadboat.com>
Cc: "Heikki Linnakangas" <hlinnaka@iki.fi>, "pgsql-hackers"
<pgsql-hackers@postgresql.org>
Date: 2023-07-03T14:52:23Z
Lists: pgsql-hackers
On Sun Jul 2, 2023 at 8:49 PM CDT, Thomas Munro wrote: > On Sun, Jul 2, 2023 at 4:25 AM Noah Misch <noah@leadboat.com> wrote: > > On Wed, Jun 28, 2023 at 01:02:21PM +1200, Thomas Munro wrote: > > > On Wed, Jun 28, 2023 at 11:03 AM Thomas Munro <thomas.munro@gmail.com> wrote: > > > > The GCC build farm has just received some SPARC hardware new enough to > > > > run modern Solaris (hostname gcc106), so if wrasse were moved over > > > > there we could finally assume all systems have POSIX 2008 (AKA > > > > SUSv4)'s locale_t. > > > > > > That would look something like this. > > > > This removes thirty-eight ifdefs, most of them located in the middle of > > function bodies. That's far more beneficial than most proposals to raise > > minimum requirements. +1 for revoking support for wrasse's OS version. > > (wrasse wouldn't move, but it would stop testing v17+.) > > Great. It sounds like I should wait a few days for any other feedback > and then push this patch. Thanks for looking. The patch looks good to me as well. Happy to rebase my other patch on this one. -- Tristan Partin Neon (https://neon.tech)
Commits
-
Don't expose Windows' mbstowcs_l() and wcstombs_l().
- 4e9fa6d56b3e 17.0 landed
-
All supported systems have locale_t.
- 8d9a9f034e92 17.0 landed
-
Remove obsolete defense against strxfrm() bugs.
- 7d3d72b55edd 16.0 landed