Horton

Re: Meson build updates

Tristan Partin <tristan@neon.tech>

View thread View on postgr.es
From: "Tristan Partin" <tristan@neon.tech>
To: "Andres Freund" <andres@anarazel.de>
Cc: <pgsql-hackers@postgresql.org>
Date: 2023-06-29T19:17:30Z
Lists: pgsql-hackers 
On Thu Jun 29, 2023 at 2:13 PM CDT, Andres Freund wrote:
> Hi,
>
> On 2023-06-29 14:07:19 -0500, Tristan Partin wrote:
> > I still think the overrides are important, at the very least for libpq,
> > but I will defer to your aforementioned decision for now.
>
> libpq makes sense to me, fwiw. Just doing it for all binaries individually
> didn't seem as obviously beneficial.
>
> FWIW, it seems it could be handled somewhat centrally for binaries, the
> bin_targets array should have all that's needed?

I will send a follow-up patch with at least libpq overridden. I will
investigate the bin_targets.

> Some things won't work from the build directory, btw. E.g. initdb or postgres
> itself.

I have already fallen victim to this! Lesson learned :).

-- 
Tristan Partin
Neon (https://neon.tech)

Commits

  1. meson: Make detection of python more robust

  2. meson: Pass more feature option through to required kwargs

  3. meson: Tie adding C++ support to the llvm Meson option

  4. meson: Fix intl misspelling

  5. meson: Use a better error message in an impossible case

  6. meson: Make some Meson style more consistent with surrounding code

  7. meson: Fix some grammar usage in Meson comments

  8. meson: Mention the correct way to disable readline support

  9. meson: Remove old comment

  10. meson: Use the not_found_dep constant

  11. meson: Attach colon to keyword argument

  12. meson: Use consistent Meson option description formats

  13. meson: Use consistent casing in Meson option descriptions

  14. meson: Remove triple-quoted strings