RE: Psql meta-command conninfo+

Maiquel Grassi <grassi@hotmail.com.br>

From: Maiquel Grassi <grassi@hotmail.com.br>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>, Nathan Bossart <nathandbossart@gmail.com>, Jim Jones <jim.jones@uni-muenster.de>, Pavel Luzanov <p.luzanov@postgrespro.ru>, Erik Wienhold <ewie@ewie.name>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-03-31T21:39:54Z
Lists: pgsql-hackers

Attachments

Note that, in the patch as posted, the column names are not
translatable.  In order to be translatable, the code needs to do
something like

appendPQExpBuffer(&buf,
                "  NULL AS \"%s\",\n"
                "  NULL AS \"%s\",\n"
                "  NULL AS \"%s\",\n"
                "  NULL AS \"%s\",\n",
                _("SSL Connection"),
                _("SSL Protocol"),
                _("SSL Cipher"),
                _("SSL Compression"));

instead of

       appendPQExpBuffer(&buf,
                         "  NULL AS \"SSL Connection\",\n"
                         "  NULL AS \"SSL Protocol\",\n"
                         "  NULL AS \"SSL Cipher\",\n"
                         "  NULL AS \"SSL Compression\",\n");


Please list me as reviewer for this patch, as I provided significant
guidance before it was even posted.

-----//-----

Hello!

(v23)

Yes Álvaro, I have already appointed you as the patch reviewer.
It's true, even before publishing it on Commifest, you have
already provided good ideas and guidance.

I adjusted the translation syntax for the SSL and GSSAPI columns.
After your validation, that is, an okay confirmation that it's fine, I'll
proceed with the others.

Test:

[postgres@localhost bin]$ ./psql -x -p 5000 -h 127.0.0.1
psql (17devel)
Type "help" for help.

postgres=# \conninfo
You are connected to database "postgres" as user "postgres" on host "127.0.0.1" at port "5000".
postgres=# \conninfo+
Current Connection Information
-[ RECORD 1 ]----------------+----------
Database                     | postgres
Authenticated User           | postgres
Socket Directory             |
Host                         | 127.0.0.1
Server Port                  | 5000
Server Address               | 127.0.0.1
Client Address               | 127.0.0.1
Client Port                  | 52966
Backend PID                  | 1693
System User                  |
Current User                 | postgres
Session User                 | postgres
Application Name             | psql
SSL Connection               | f
SSL Protocol                 |
SSL Cipher                   |
SSL Compression              |
GSSAPI Authenticated         | f
GSSAPI Principal             |
GSSAPI Encrypted             | f
GSSAPI Credentials Delegated | f

Regards,
Maiquel Grassi.

Commits

  1. psql: Change new \conninfo to use SSL instead of TLS

  2. Change \conninfo to use tabular format

  3. Update extension lookup routines to use the syscache

  4. Improve COPY TO performance when server and client encodings match

  5. doc: Remove superfluous bracket in synopsis

  6. Remove psql support for server versions preceding 9.2.