Re: Transaction timeout

x4mmm@yandex-team.ru

From: "Andrey M. Borodin" <x4mmm@yandex-team.ru>

To: Junwang Zhao <zhjwpku@gmail.com>

Cc: Li Japin <japinli@hotmail.com>, 邱宇航 <iamqyh@gmail.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, Andrey Borodin <amborodin86@gmail.com>, Andres Freund <andres@anarazel.de>, Michael Paquier <michael.paquier@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2024-01-01T14:28:33Z

Lists: pgsql-hackers

Attachments

v20-0001-Introduce-transaction_timeout.patch (application/octet-stream) patch v20-0001
v20-0004-fix-reschedule-timeout-for-each-commmand.patch (application/octet-stream) patch v20-0004
v20-0003-Try-to-enable-transaction_timeout-before-next-co.patch (application/octet-stream) patch v20-0003
v20-0002-Add-better-tests-for-transaction_timeout.patch (application/octet-stream) patch v20-0002


> On 29 Dec 2023, at 16:15, Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:

PFA v20. Code steps are intact.

Further refactored tests:
    1. Check termination of active and idle queries (previously tests from Li were testing only termination of idle query)
    2. Check timeout reschedule (even when last active query was 'SET transaction_timeout')
    3. Check that timeout is not rescheduled by new queries (Nik's case)


Do we have any other open items?
I've left 'make check-timeouts' in isolation directory, it's for development purposes. I think we should remove this before committing. Obviously, all patch steps are expected to be squashed before commit.


Best regards, Andrey Borodin.

Commits

Add TAP tests for timeouts
- eeefd4280f6e 17.0 landed
Remove flaky isolation tests for timeouts
- a661bf7b0f56 17.0 landed
Followup fixes for transaction_timeout
- bf82f43790a6 17.0 landed
Introduce transaction_timeout
- 51efe38cb92f 17.0 landed
On systems that have setsid(2) (which should be just about everything except
- 3ad0728c817b 8.2.0 cited