Re: pg14 psql broke \d datname.nspname.relname

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Greg Stark <stark@mit.edu>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Justin Pryzby <pryzby@telsasoft.com>, Stephen Frost <sfrost@snowman.net>, Peter Geoghegan <pg@bowt.ie>

Date: 2022-04-18T19:39:17Z

Lists: pgsql-hackers

Attachments

v9-0001-Reject-patterns-with-too-many-parts-or-wrong-db.patch (application/octet-stream) patch v9-0001
(unnamed) (text/plain)


> On Apr 8, 2022, at 4:11 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> 
> I don't personally see how we're going to come out ahead with that
> approach, but if you or Tom or someone else want to put something
> together, that's fine with me. I'm not stuck on this approach, I just
> don't see how we come out ahead with the type of thing you're talking
> about. I mean we could return the error text, but it's only to a
> handful of places, so it just doesn't really seem like a win over what
> the patch is already doing.

Since there hasn't been any agreement on that point, I've just rebased the patch to apply cleanly against the current master:

Commits

Remove some recently-added pg_dump test cases.
- 75a006beef6c 14.3 landed
- a66e722cc118 15.0 landed
Allow db.schema.table patterns, but complain about random garbage.
- 4a66300acd8c 14.3 landed
- d2d35479796c 15.0 landed
Improve error handling of HMAC computations
- 5513dc6a304d 15.0 cited
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 cited