Horton

Re: The pgperltidy diffs in HEAD

Daniel Gustafsson <daniel@yesql.se>

View thread
From: Daniel Gustafsson <daniel@yesql.se>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-25T19:36:33Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Check for correct version of perltidy

> On 25 Nov 2025, at 20:31, Álvaro Herrera <alvherre@kurilemu.de> wrote:
> 
> On 2025-Nov-25, Daniel Gustafsson wrote:
> 
>> Agreed. Perhaps something like the attached would work?
> 
> Hmm, I got this
> 
> src/tools/pgindent/pgperltidy: 10: [: 0: unexpected operator
> 
> $ ls -l /bin/sh
> lrwxrwxrwx 1 root root 4 feb  4  2025 /bin/sh -> dash*
> 
> (Seems to work ok silently with bash.)

If you replace the if statement with the one below using test, does that make
it work?

	if test $? = 1; then

--
Daniel Gustafsson