Re: wait event and archive_command

Sascha Kuhl <yogidabanli@gmail.com>

From: Sascha Kuhl <yogidabanli@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-10T11:25:58Z
Lists: pgsql-hackers
Great, so great. Thanks you

Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> schrieb am Mi.,
10. Nov. 2021, 12:20:

> On Mon, Nov 1, 2021 at 2:31 PM Fujii Masao <masao.fujii@oss.nttdata.com>
> wrote:
> > On 2021/10/21 23:55, Bharath Rupireddy wrote:
> > >> Also how about adding wait events for other commands like
> > >> archive_cleanup_command, restore_command and recovery_end_command?
> > >
> > > +1 for the wait event.
> >
> > Thanks!
> > I added the wait events for also restore_command, etc into the patch.
> > I attached that updated version of the patch.
>
> Thanks for the patch. It looks good to me other than the following comment:
>
> 1) Can't we determine the wait event type based on commandName in
> ExecuteRecoveryCommand instead of passing it as an extra param?
>
> Regards,
> Bharath Rupireddy.
>
>
>

Commits

  1. Report wait events for local shell commands like archive_command.