Horton

Re: postgres.h included from relcache.h - but removing it breaks pg_upgrade

Alexander Korotkov <aekorotkov@gmail.com>

View thread View on postgr.es
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, Alexander Korotkov <akorotkov@postgresql.org>
Date: 2021-09-17T23:24:17Z
Lists: pgsql-hackers 
On Tue, Sep 14, 2021 at 5:40 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I noticed that postgres.h is included from relcache.h (starting in [1]) and
> > wanted to fix that - it violates our usual policy against including postgres.h
> > from within headers.
>
> Ugh, yeah, that's entirely against policy.

I see. This is my oversight, sorry for that.

------
Regards,
Alexander Korotkov

Commits

  1. Split macros from visibilitymap.h into a separate header

  2. Implement operator class parameters