Horton

Re: Partitioned tables and covering indexes

Alexander Korotkov <a.korotkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Peter Geoghegan <pg@bowt.ie>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Jaime Casanova <jaime.casanova@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-04-12T10:14:30Z
Lists: pgsql-hackers 
On Thu, Apr 12, 2018 at 1:14 AM, Teodor Sigaev <teodor@sigaev.ru> wrote:

> That's the idea that I tried to express. The point is that we need to
>>> tell the user that there is no need to worry about it, rather than
>>> that they're wrong to ask about it. Though we should probably actually
>>> just throw an error.
>>>
>>
>> Or maybe it should be the collation of the underlying table columns.
>> Otherwise the collation returned by an index-only scan would be
>> different from a table scan, no?
>>
> +1, dangerous


I'm OK with collation of included columns to be the same as collation
of underlying table columns.  But I still think we should throw an error
when user is trying to specify his own collation of included columns.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Fix interference between covering indexes and partitioned tables

  2. Cleanup covering infrastructure

  3. Rename IndexInfo.ii_KeyAttrNumbers array