Horton

Re: GIN predicate locking slows down valgrind isolationtests tremendously

Alexander Korotkov <a.korotkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, Teodor Sigaev <teodor@sigaev.ru>, Shubham Barai <shubhambaraiss@gmail.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>
Date: 2018-12-28T00:46:41Z
Lists: pgsql-hackers 
On Thu, Dec 27, 2018 at 7:58 PM Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> On 12/24/18 5:47 PM, Andrew Dunstan wrote:
> > On 12/24/18 5:25 PM, Alexander Korotkov wrote:
> >> BTW, patch for reducing isolation testing for gin predicate locking is
> >> attached.  Could anybody check its execution time with valgrind (and
> >> compare with execution time of previous test suite)?
> >
> > Will try if I get some time to spare in the next 72 hours or so
>
> The latest test on lousyjack ran with this applied. The isolation tests
> went from 285 minutes to 65 minutes.
>
> So +1 for applying this.

Thank you very much!
So, pushed.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Reduce length of GIN predicate locking isolation test suite

  2. Remove entry tree root conflict checking from GIN predicate locking