Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alexander Korotkov <a.korotkov@postgrespro.ru>

From: Alexander Korotkov <a.korotkov@postgrespro.ru>

To: Alexey Kondratov <a.kondratov@postgrespro.ru>

Cc: Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@2ndquadrant.com>, Liudmila Mantrova <l.mantrova@postgrespro.ru>, Thomas Munro <thomas.munro@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, David Steele <david@pgmasters.net>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru

Date: 2020-02-26T19:03:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move frontend-side archive APIs from src/common/ to src/fe_utils/
- 8d8b89266ca0 13.0 landed
- a3b2bf1fe7ce 14.0 landed
Add -c/--restore-target-wal to pg_rewind
- a7e8ece41cf7 13.0 landed
Move routine definitions of xlogarchive.c to a new header file
- 616ae3d2b056 13.0 landed
Move routine building restore_command to src/common/
- e09ad07b21a2 13.0 landed
Integrate recovery.conf into postgresql.conf
- 2dedf4d9a899 12.0 cited

Attachments

v16-0001-pg_rewind-Add-options-to-restore-WAL-files.patch (application/octet-stream) patch v16-0001

On Tue, Feb 25, 2020 at 1:48 PM Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
>
> I think usage of chmod() deserves comment.  As I get default
> permissions are sufficient for work, but we need to set them to
> satisfy 'check PGDATA permissions' test.


I've added this comment myself.  I've also fixes some indentation.
Patch now looks good to me.  I'm going to push it if no objections.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company