Horton

Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb)

Alexander Korotkov <aekorotkov@gmail.com>

View thread View on postgr.es
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, Alexander Korotkov <akorotkov@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-14T00:42:28Z
Lists: pgsql-hackers 
On Sun, Feb 14, 2021 at 1:59 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
> > Alexander Korotkov <aekorotkov@gmail.com> writes:
> >> On Fri, Feb 12, 2021 at 8:19 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >>> Once this does settle, should we consider back-patching so that it's
> >>> possible to run alignment checks in the back branches too?
>
> >> +1
>
> > Let's make sure we have a clean set of builds and then do that.
>
> The buildfarm seems to be happy --- the active members that haven't
> reported in should be unaffected by this patch, either because their
> compiler versions are too old or because they're not x86 architecture.
> So I went ahead and back-patched, and have adjusted longfin to apply
> the -fsanitize switch in all branches.

Perfect, thank you very much!

------
Regards,
Alexander Korotkov

Commits

  1. pg_attribute_no_sanitize_alignment() macro

  2. Tweak compiler version cutoff for no_sanitize("alignment") support.

  3. Implementation of subscripting for jsonb