Re: [PATCH] Check snapshot argument of index_beginscan and family

Hi!

On Mon, Nov 28, 2022 at 1:30 PM Aleksander Alekseev
<aleksander@timescale.com> wrote:
> Thanks for the feedback!
>
> > I think it's a nice catch and worth fixing. The one thing I don't
> > agree with is using asserts for handling the error that can appear
> > because most probably the server is built with assertions off and in
> > this case, there still will be a crash in this case. I'd do this with
> > report ERROR. Otherwise, the patch looks right and worth committing.
>
> Normally a developer is not supposed to pass NULLs there so I figured
> having extra if's in the release builds doesn't worth it. Personally I
> wouldn't mind using ereport() but my intuition tells me that the
> committers are not going to approve this :)
>
> Let's see what the rest of the community thinks.

I think this is harmless assertion patch.  I'm going to push this if
no objections.

------
Regards,
Alexander Korotkov