Horton

Re: WIP: index support for regexp search

Alexander Korotkov <aekorotkov@gmail.com>

View thread
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Erikjan Rijkers <er@xs4all.nl>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Heikki Linnakangas <hlinnakangas@vmware.com>, Tomas Vondra <tv@fuzzy.cz>, pgsql-hackers <pgsql-hackers@postgresql.org>, Pavel Stìhule <pavel.stehule@gmail.com>
Date: 2013-04-02T21:54:16Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix filling of postmaster.pid in bootstrap/standalone mode.

  2. Add explicit casts in ilist.h's inline functions.

Attachments

On Wed, Apr 3, 2013 at 12:36 AM, Erikjan Rijkers <er@xs4all.nl> wrote:

> On Mon, April 1, 2013 23:15, Alexander Korotkov wrote:
>
> [trgm-regexp-0.14.patch.gz]
>
> Hi Alexander,
>

Hi Erik!


> Something went wrong in this version of the patch: many (most) queries
> that were earlier
> spectacularly fast have become slow, often slower than a seqscan or only
> marginally faster. See
> the attached numbers; it compares head(seqscan) with trgm-regex patch
> versions 13 and 14.
>
> I did not even complete the test-run because version 14 is so clearly
> inferior to 13 (and earlier,
> as far as I can remember).
>
> (let me know if you want the whole result, I can run it overnight)
>

Yes, there was bug in new color map scan implementation. It was fixed in
attached version. Could you re-run tests please?
Attached version of patch also addresses problem that we now using API it's
not correct to use special values of color number. It introduces additional
structure ExtendedColor which contain ExtendedColorClass field for handling
additional "virtual" colors introduced by analysis.

------
With best regards,
Alexander Korotkov.