Re: pgsql: Implement pg_wal_replay_wait() stored procedure

Alexander Korotkov <aekorotkov@gmail.com>

From: Alexander Korotkov <aekorotkov@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Peter Eisentraut <peter@eisentraut.org>, Alexander Korotkov <akorotkov@postgresql.org>, pgsql-committers@lists.postgresql.org

Date: 2024-09-01T23:55:50Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert pg_wal_replay_wait() stored procedure
- 3a7ae6b3d91e 18.0 landed
Add 'no_error' argument to pg_wal_replay_wait()
- e546989a269d 18.0 landed
Refactor WaitForLSNReplay() to return the result of waiting
- 73da6b8d1b3e 18.0 landed
Make WaitForLSNReplay() issue FATAL on postmaster death
- 6cfebfe88b9a 18.0 landed
Move LSN waiting declarations and definitions to better place
- 5035172e4ab5 18.0 landed
Update oid for pg_wal_replay_wait() procedure
- e658038772f5 18.0 landed
Move pg_wal_replay_wait() to xlogfuncs.c
- 014f9f34d252 18.0 landed
Implement pg_wal_replay_wait() stored procedure
- 3c5db1d6b016 18.0 cited

Attachments

v1-0001-Move-pg_wal_replay_wait-to-xlogfuncs.c.patch (application/octet-stream) patch v1-0001

On Mon, Sep 2, 2024 at 2:28 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Sun, Sep 01, 2024 at 10:35:27PM +0300, Alexander Korotkov wrote:
> > This path hasn't changes since the patch revision when it was a
> > utility command.  I agree that this doesn't look like proper path for
> > stored procedure.  But I don't think src/backend/utils/adt is
> > appropriate path either, because it's not really about data type.
> > pg_wal_replay_wait() looks a good neighbor for
> > pg_wal_replay_pause()/pg_wal_replay_resume() and other WAL-related
> > functions.  So, what about moving it to src/backend/access/transam?
>
> Moving the new function to xlogfuncs.c while publishing
> WaitForLSNReplay() makes sense to me.

Thank you for proposal.  I like this.

Could you, please, check the attached patch?

------
Regards,
Alexander Korotkov
Supabase