Horton

Re: Reopen logfile on SIGHUP

Alexander Korotkov <a.korotkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>, sk@zsrv.org, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Greg Stark <stark@mit.edu>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, Grigory Smolkin <g.smolkin@postgrespro.ru>
Date: 2018-08-29T09:01:58Z
Lists: pgsql-hackers 
Hi!

On Wed, Aug 29, 2018 at 5:05 AM Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> At Tue, 28 Aug 2018 18:50:31 +0300, Alexander Korotkov <a.korotkov@postgrespro.ru> wrote in <CAPpHfduqEyyjLXCNx_t7K2ugCDGVW7WLKL+zrfDEd5wzkvmg-w@mail.gmail.com>
> > Also I found that this new pg_ctl isn't covered with tests at all.  So
> > I've added very simple tap tests, which ensures that when log file was
> > renamed, it reappeared again after pg_ctl logrotate.  I wonder how
> > that would work on Windows.  Thankfully commitfest.cputube.org have
> > Windows checking facility now.
>
> Thanks for the test. Documentaion and help message looks fine
> including the changed ordering. (180 seconds retry may be a bit
> too long but I'm fine with it.)

Thank you for the comments.  My idea about retry logic was to provide
the similar behavior to poll_query_until().

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Implement "pg_ctl logrotate" command