Horton

Re: Concurrency bug in amcheck

Alexander Korotkov <aekorotkov@gmail.com>

View thread View on postgr.es
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Michail Nikolaev <michail.nikolaev@gmail.com>
Date: 2020-08-04T14:27:09Z
Lists: pgsql-hackers

Attachments

Hi, Peter!

On Sat, Aug 1, 2020 at 3:23 AM Peter Geoghegan <pg@bowt.ie> wrote:

> On Wed, May 13, 2020 at 4:06 PM Peter Geoghegan <pg@bowt.ie> wrote:
> > On Mon, May 11, 2020 at 5:56 AM Alexander Korotkov
> > <a.korotkov@postgrespro.ru> wrote:
> > > Thank you.  2nd patch is proposed for master and makes btree page
> > > unlink remove all the items from the page being deleted.
> >
> > This looks good, but can we do the
> > wal_consistency_checking/btree_mask() improvement, too?
>
> You never got around to committing the second patch (or the
> wal_consistency_checking stuff). Are you planning on picking it up
> again?
>

Thank you for your reminder.   Revised patch is attached.  Now, the
contents of deleted btree pages isn't masked.  I've checked that
installcheck passes with wal_consistency_checking='Btree'.  I'm going to
push this if no objections.

------
Regards,
Alexander Korotkov

Commits

  1. Remove btree page items after page unlink

  2. Fix amcheck for page checks concurrent to replay of btree page deletion