Re: [PATCH] Incremental sort

Alexander Korotkov <a.korotkov@postgrespro.ru>

From: Alexander Korotkov <a.korotkov@postgrespro.ru>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Mithun Cy <mithun.cy@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2017-10-03T15:26:52Z

Lists: pgsql-hackers

On Tue, Oct 3, 2017 at 2:52 PM, Robert Haas <robertmhaas@gmail.com> wrote:

> On Mon, Oct 2, 2017 at 12:37 PM, Alexander Korotkov
> <a.korotkov@postgrespro.ru> wrote:
> > I've applied patch on top of c12d570f and rerun the same benchmarks.
> > CSV-file with results is attached.  There is no dramatical changes.
> There
> > is still minority of performance regression cases while majority of cases
> > has improvement.
>
> Yes, I think these results look pretty good.  But are these times in
> seconds?  You might need to do some testing with bigger sorts.


Good point.  I'll rerun benchmarks with larger dataset size.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

Further adjustments to Hashagg EXPLAIN ANALYZE output
- 40efbf8706cd 14.0 cited
Rework EXPLAIN format for incremental sort
- 6a918c3ac8a6 13.0 landed
Fix typos and improve incremental sort comments
- 1a40d37a9faf 13.0 landed
Stabilize incremental_sort tests
- cea09246e578 13.0 landed
Minor improvements in Incremental Sort explain
- d22782a5392f 13.0 landed
Consider Incremental Sort paths at additional places
- ba3e76cc571e 13.0 landed
Fix representation of SORT_TYPE_STILL_IN_PROGRESS.
- c7654f6a3779 13.0 landed
Fix failures in incremental_sort due to number of workers
- 23ba3b5ee278 13.0 landed
Fix show_incremental_sort_info with force_parallel_mode
- 7d6d82a52493 13.0 landed
Implement Incremental Sort
- d2d8a229bc58 13.0 landed
Fix handling of "Subplans Removed" field in EXPLAIN output.
- 7d91b604d9b5 13.0 cited
Fix EXPLAIN (SETTINGS) to follow policy about when to print empty fields.
- 3ec20c7091e9 13.0 cited
Ensure plpgsql result tuples have the right composite type marking.
- 5683b34956b4 13.0 cited
Propagate sort instrumentation from workers back to leader.
- bf11e7ee2e36 11.0 cited
Make new regression test case parallel-safe, and improve its output.
- 1177ab1dabf7 11.0 cited
Push limit through subqueries to underlying sort, where possible.
- 1f6d515a67ec 11.0 cited
Fix inappropriate printing of never-measured times in EXPLAIN.
- 4b234fd8bf21 9.6.0 cited
Fix some infelicities in EXPLAIN output for parallel query plans.
- 8ebb69f85445 9.6.0 cited