Re: Some problems regarding the self-join elimination code

Alexander Korotkov <aekorotkov@gmail.com>

From: Alexander Korotkov <aekorotkov@gmail.com>
To: Andrei Lepikhov <lepihov@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, Dean Rasheed <dean.a.rasheed@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-05-01T19:01:07Z
Lists: pgsql-hackers
On Thu, May 1, 2025 at 8:22 PM Andrei Lepikhov <lepihov@gmail.com> wrote:
> On 1/5/2025 14:11, Alexander Korotkov wrote:
> >     3. Should the ChangeVarNodesWalkExpression function return the walker's
> >     returning value?
> >
> >
> > Done.
> Thanks for your efforts! Looks good to me.

Thank you.  I'm going to push this if there is no objections.

------
Regards,
Alexander Korotkov
Supabase



Commits

  1. Refactor ChangeVarNodesExtended() using the custom callback

  2. Fixes for ChangeVarNodes_walker()

  3. Restore comments in ChangeVarNodesExtended()