Fix bloom WAL tap test
Alexander Korotkov <a.korotkov@postgrespro.ru>
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-06T13:08:07Z
Lists: pgsql-hackers
Attachments
- fix-bloom-wal-check.patch (application/octet-stream) patch
Hi!
I just realized that these lines of contrib/bloom/t/001_wal.pl don't check
that queries give same results on master and standby. They just check that
*return codes* of psql are equal.
# Run test queries and compare their result
> my $master_result = $node_master->psql("postgres", $queries);
> my $standby_result = $node_standby->psql("postgres", $queries);
> is($master_result, $standby_result, "$test_name: query result matches");
Attached patch fixes this problem by using safe_psql() which returns psql
output instead of return code. For safety, this patch replaces psql() with
safe_psql() in other places too.
I think this should be backpatched to 9.6 as bugfix.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Commits
-
Tighten test in contrib/bloom/t/001_wal.pl.
- 859662c26cf9 9.6.7 landed
- d33fc27e8df6 10.2 landed
- 7e60e678615b 11.0 landed