Horton

Re: Improve search for missing parent downlinks in amcheck

Alexander Korotkov <a.korotkov@postgrespro.ru>

View thread View on postgr.es
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-02-18T10:17:18Z
Lists: pgsql-hackers

Attachments

On Tue, Feb 18, 2020 at 1:15 PM Alexander Korotkov
<a.korotkov@postgrespro.ru> wrote:
> On Fri, Jan 24, 2020 at 4:31 AM Peter Geoghegan <pg@bowt.ie> wrote:
> > On Wed, Jan 22, 2020 at 6:41 PM Alexander Korotkov
> > <a.korotkov@postgrespro.ru> wrote:
> > > Rebased patch is attached.  Sorry for so huge delay.
> >
> > I really like this patch. Your interest in amcheck is something that
> > makes me feel good about having put so much work into it myself.
> >
> > Here are some review comments:
>
> Great, thank you very much!

Sorry, I've forgot to commit some comments before publishing a patch.
The right version is attached.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Improve checking of child pages in contrib/amcheck.

  2. Don't rely on estimates for amcheck Bloom filters.