Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages

Alexander Korotkov <aekorotkov@gmail.com>

From: Alexander Korotkov <aekorotkov@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: vignesh C <vignesh21@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila16@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>
Date: 2025-07-17T21:09:29Z
Lists: pgsql-hackers

Attachments

On Wed, Jul 16, 2025 at 1:12 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Jul 15, 2025 at 09:19:50PM +0300, Alexander Korotkov wrote:
> > Thank you for your efforts on this subject.  Actually, I was planning
> > to work on pushing this after the release freeze ends for v18.  I'd
> > like to do this at least for tests as they were initially committed by
> > me.
> >
> > Anyway, please, hold on pushing this for ~1 day to let me do final
> > review of this.
>
> If you want to apply all of this yourself, please feel free, of
> course.

Thank you!
I went trough the patchset.  Everything looks good to me.  I only did
some improvements to comments and commit messages.  I'm going to push
this if no objections.

------
Regards,
Alexander Korotkov
Supabase

Commits

  1. Fix infinite wait when reading a partially written WAL record

  2. Improve the stability of the recovery test 047_checkpoint_physical_slot

  3. Improve recovery test 046_checkpoint_logical_slot