Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug

Alexander Korotkov <a.korotkov@postgrespro.ru>

From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: David Steele <david@pgmasters.net>
Cc: Teodor Sigaev <teodor@sigaev.ru>, Robert Haas <robertmhaas@gmail.com>, Jan Przemysław Wójcik <jan.przemyslaw.wojcik@gmail.com>, Postgres-Bugs <pgsql-bugs@postgresql.org>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Liudmila Mantrova <l.mantrova@postgrespro.ru>
Date: 2018-03-21T12:25:11Z
Lists: pgsql-bugs, pgsql-hackers
On Tue, Mar 6, 2018 at 7:59 PM, David Steele <david@pgmasters.net> wrote:

> On 3/6/18 7:04 AM, Teodor Sigaev wrote:
> >> I agree with Teodor (upthread, not quoted here) that the documentation
> >> could use some editing.
> >>
> >> I started to do it myself, but quickly realized I have no knowledge of
> >> the content.  I'm afraid I would destroy the meaning while updating the
> >> grammar.
> >>
> >> Anyone understand the subject matter well enough to review the
> >> documentation?
> >
> > Liudmila tried to improve docs in Alexander's patchset.
> >
> > https://www.postgresql.org/message-id/f43b242d-000c-f4c8-cb8
> b-d37e9752cd93@postgrespro.ru
>
> This looks good to me with a few minor exceptions:
>
> +   <function>word_similarity(text, text)</function> requires further
> +   explanation. Consider the following example:
>
> Maybe too verbose?  I think "<function>word_similarity(text,
> text)</function> requires further explanation." can be removed entirely.
>
> +   string.  However, this function does not add paddings to the
>
> "add padding"
>
> > BTW, adding Liudmila's message to commitfest task
> > (https://commitfest.postgresql.org/17/1403/) doesn't work
>
> Doesn't work for me either.
>
> Alexander, can you post the final patches to the thread so they show up
> in the CF app?
>

I'm sorry for not updating patches, I've missed this message in the thread.

BTW, Teodor have pushed fix to the documentation up to 9.6.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=
aea7c17e86e99a7ed4da489b3df2b5493b5e5e95

And new function strict_word_similarity() to PostgreSQL 11.
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=
be8a7a6866276b228b4ffaa3003e1dc2dd1d140a

Could someone put this information to stackoverflow?
https://stackoverflow.com/questions/46966360/postgres-word-similarity-not-comparing-words
I don't have enough of reputation to comment.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Update trigram example in docs to correct state

  2. Add strict_word_similarity to pg_trgm module

  3. Rework word_similarity documentation, make it close to actual algorithm.