Re: Removing unneeded self joins

Alexander Korotkov <aekorotkov@gmail.com>

From: Alexander Korotkov <aekorotkov@gmail.com>

To: Richard Guo <guofenglinux@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Tender Wang <tndrwang@gmail.com>, Daniel Gustafsson <daniel@yesql.se>, Andrei Lepikhov <lepihov@gmail.com>, Ranier Vilela <ranier.vf@gmail.com>, Alena Rybakina <a.rybakina@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Alexander Lakhin <exclusion@gmail.com>, "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, Michał Kłeczek <michal@kleczek.org>, Dean Rasheed <dean.a.rasheed@gmail.com>

Date: 2025-04-07T13:11:55Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove GUC_NOT_IN_SAMPLE from enable_self_join_elimination
- 717d0e8dd945 18.0 landed
Put enable_self_join_elimination into postgresql.conf.sample
- c2d329260cd8 18.0 landed
Get rid of ojrelid local variable in remove_rel_from_query()
- e167191dc146 18.0 landed
Implement Self-Join Elimination
- fc069a3a6319 18.0 cited
Revert: Remove useless self-joins
- d1d286d83c0e 17.0 landed
Replace lateral references to removed rels in subqueries
- 466979ef031a 17.0 landed
Replace relids in lateral subquery parse tree during SJE
- 489072ab7a9e 17.0 landed
Forbid SJE with result relation
- 8c441c082797 17.0 landed
Fix misuse of RelOptInfo.unique_for_rels cache by SJE
- 30b4955a4668 17.0 landed
Replace the relid in some missing fields during SJE
- a7928a57b9f0 17.0 landed
Revert 56-bit relfilenode change and follow-up commits.
- a448e49bcbe4 16.0 cited
Stabilize timetz test across DST transitions.
- 4a071afbd056 14.0 cited
Speed up finding EquivalenceClasses for a given set of rels
- 3373c7155350 13.0 cited
Fix mark-and-restore-skipping test case to not be a self-join.
- 24d08f3c0a1f 12.0 landed

Hi, Richard!

On Mon, Apr 7, 2025 at 6:12 AM Richard Guo <guofenglinux@gmail.com> wrote:
>
> FWIW, I reported some issues with this commit in [1].  Any thoughts on
> how to fix them?
>
> [1] https://www.postgresql.org/message-id/flat/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com

Thank you for pointing.  Looking into that!

------
Regards,
Alexander Korotkov
Supabase