Re: WIP: index support for regexp search

Alexander Korotkov <aekorotkov@gmail.com>

From: Alexander Korotkov <aekorotkov@gmail.com>

To: Tomas Vondra <tv@fuzzy.cz>

Cc: pgsql-hackers@postgresql.org

Date: 2012-11-20T20:01:51Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix filling of postmaster.pid in bootstrap/standalone mode.
- c29947722955 9.3.0 cited
Add explicit casts in ilist.h's inline functions.
- e78d288c895b 9.3.0 cited

Attachments

trgm-regexp-0.4.patch.gz (application/x-gzip) patch

On Tue, Nov 20, 2012 at 3:02 AM, Tomas Vondra <tv@fuzzy.cz> wrote:

> 2) It's common to use upper-case names for macros, but trgm.h defines
>    macro "iswordchr" - I see it's moved from trgm_op.c but maybe we
>    could make it a bit more correct?
>
> 3) I see there are two '#ifdef KEEPONLYALNUM" blocks right next to each
>    other in trgm.h - maybe it'd be a good idea to join them?
>
> 4) The two new method prototypes at the end of trgm.h use different
>    indendation than the rest (spaces only instead of tabs).
>
These issues are fixed in attached patch.
Additionally 3 new macros are
introduced: MAX_RESULT_STATES, MAX_RESULT_ARCS, MAX_RESULT_PATHS. They are
limiting resources usage during regex processing.

------
With best regards,
Alexander Korotkov.