Re: GIN predicate locking slows down valgrind isolationtests tremendously
Alexander Korotkov <a.korotkov@postgrespro.ru>
From: Alexander Korotkov <a.korotkov@postgrespro.ru>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>,
pgsql-hackers <pgsql-hackers@postgresql.org>, Teodor Sigaev <teodor@sigaev.ru>, Shubham Barai <shubhambaraiss@gmail.com>, Dmitry Ivanov <d.ivanov@postgrespro.ru>
Date: 2018-12-25T01:17:13Z
Lists: pgsql-hackers
On Tue, Dec 25, 2018 at 1:48 AM Andrew Dunstan <andrew.dunstan@2ndquadrant.com> wrote: > On 12/24/18 5:25 PM, Alexander Korotkov wrote: > > On Fri, Dec 21, 2018 at 1:50 AM Alexander Korotkov > > <a.korotkov@postgrespro.ru> wrote: > >> чт, 20 дек. 2018 г., 2:22 Andres Freund andres@anarazel.de: > >>> On 2018-12-03 16:07:40 -0800, Andres Freund wrote: > >>>> As far as I can tell that increase comes laregely from the new GIN > >>>> tests. Could one of you please look at keeping the test time increase > >>>> to something more reasonable? > >>> Ping? > >>> > >>> It's also one of the slowest tests outside of valgrind... > >> I'm going to take a look on that. > > BTW, patch for reducing isolation testing for gin predicate locking is > > attached. Could anybody check its execution time with valgrind (and > > compare with execution time of previous test suite)? > > Will try if I get some time to spare in the next 72 hours or so Thank you! ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Commits
-
Reduce length of GIN predicate locking isolation test suite
- fcdda202bcf8 11.2 landed
- 0c6f4f9212cf 12.0 landed
-
Remove entry tree root conflict checking from GIN predicate locking
- b450abd2551e 12.0 landed
- fd7c08195592 11.2 landed