Horton

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

Alexander Korotkov <aekorotkov@gmail.com>

View thread View on postgr.es
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Mason Sharp <masonlists@gmail.com>, Pavel Borisov <pashkin.elfe@gmail.com>, vignesh C <vignesh21@gmail.com>
Date: 2023-01-09T10:10:56Z
Lists: pgsql-hackers

Attachments

Hi Aleksander,

On Mon, Jan 9, 2023 at 12:56 PM Aleksander Alekseev
<aleksander@timescale.com> wrote:
> > I'm going to push this if no objections.
>
> I took a fresh look at the patch and it LGTM. I only did a few
> cosmetic changes, PFA v7.
>
> Changes since v6 are:

Thank you for looking into this.  It appears that I've applied changes
proposed by Mason to v5, not v6.  That lead to comment mismatch with
the code that you've noticed.  v8 should be correct.  Please, recheck.

------
Regards,
Alexander Korotkov

Commits

  1. Add EvalPlanQual delete returning isolation test

  2. Allow locking updated tuples in tuple_update() and tuple_delete()

  3. Revert 764da7710b

  4. Revert 11470f544e

  5. Evade extra table_tuple_fetch_row_version() in ExecUpdate()/ExecDelete()

  6. Check that xmax didn't commit in freeze check.